cjolivier01 commented on a change in pull request #9784: Fix for the case where
there are no detections
URL: https://github.com/apache/incubator-mxnet/pull/9784#discussion_r167913803
##########
File path: example/ssd/detect/detector.py
##########
@@ -43,6 +43,7 @@ class Detector(object):
ctx : mx.ctx
device to use, if None, use mx.cpu() as default context
"""
+ CLASS = 0
Review comment:
"Constants are usually defined on a module level and written in all capital
letters with underscores separating words. Examples include MAX_OVERFLOW and
TOTAL."
This is at class-level, right? Would a derivative not want to override the
value?
Is this done elsewhere? I haven't seen thyis done within classes elsewhere,
but maybe I'm wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
