cjolivier01 commented on a change in pull request #9771: Modify NDArrayIter
constructor to receive tuple (i.e. dict in Python)?
URL: https://github.com/apache/incubator-mxnet/pull/9771#discussion_r167938189
##########
File path: scala-package/core/src/main/scala/ml/dmlc/mxnet/io/NDArrayIter.scala
##########
@@ -38,15 +38,14 @@ import scala.collection.immutable.ListMap
* the size of data does not match batch_size. Roll over is intended
* for training and can cause problems if used for prediction.
*/
-class NDArrayIter (data: IndexedSeq[NDArray], label: IndexedSeq[NDArray] =
IndexedSeq.empty,
- private val dataBatchSize: Int = 1, shuffle: Boolean = false,
- lastBatchHandle: String = "pad",
- dataName: String = "data", labelName: String = "label")
extends DataIter {
+class NDArrayIter (data: IndexedSeq[(String, NDArray)], label:
IndexedSeq[(String, NDArray)],
+ private val dataBatchSize: Int, shuffle: Boolean,
+ lastBatchHandle: String) extends DataIter {
Review comment:
So then can it be structured in such a way that the primary constructor
serves as the "common" portion, passing it a translation (of sorts) of the
multiple input types?
Reading that, I didn't see where it said it can;t call other functions, but
I'll take your word for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
