piiswrong commented on a change in pull request #9777: [MX-9588] Add micro averaging strategy for F1 metric URL: https://github.com/apache/incubator-mxnet/pull/9777#discussion_r167971498
########## File path: python/mxnet/metric.py ########## @@ -475,8 +475,84 @@ def update(self, labels, preds): self.num_inst += num_samples +class _BinaryClassificationMixin(object): + """ + Private mixin for keeping track of TPR, FPR, TNR, FNR counts for a classification metric. Review comment: Could you add more explanation of what this does? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services