piiswrong commented on a change in pull request #9738: Add Support for int64
URL: https://github.com/apache/incubator-mxnet/pull/9738#discussion_r167975658
##########
File path: src/operator/mxnet_op.h
##########
@@ -204,6 +204,15 @@ inline int get_num_threads<cpu>(const int N) {
}
+#define MXNET_ADD_ALL_TYPES \
+ .add_enum("float32", mshadow::kFloat32) \
+ .add_enum("float64", mshadow::kFloat64) \
+ .add_enum("float16", mshadow::kFloat16) \
+ .add_enum("uint8", mshadow::kUint8) \
Review comment:
also add int8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
