piiswrong commented on a change in pull request #9790: make array.reshape 
compatible with numpy
URL: https://github.com/apache/incubator-mxnet/pull/9790#discussion_r168293201
 
 

 ##########
 File path: python/mxnet/ndarray/ndarray.py
 ##########
 @@ -926,12 +926,12 @@ def _at(self, idx):
             self.handle, mx_uint(idx), ctypes.byref(handle)))
         return NDArray(handle=handle, writable=self.writable)
 
-    def reshape(self, shape):
+    def reshape(self, *shape, **kwargs):
 
 Review comment:
   (self, *args, shape=None)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to