larroy commented on a change in pull request #9677: Refactor operators and add
MKLDNN
URL: https://github.com/apache/incubator-mxnet/pull/9677#discussion_r168580648
##########
File path: src/common/exec_utils.h
##########
@@ -43,19 +43,61 @@ namespace common {
indices are not recorded
* \return true if any source NDArray need to cast storage
*/
-inline bool SetupDefaultBlobs(const std::vector<NDArray>& src,
- std::vector<TBlob> *blobs,
- std::vector<NDArray> *temp_src,
- std::vector<NDArray> *temp_dst,
- std::unordered_map<uint32_t, uint32_t> *idx_map
= nullptr) {
+inline bool SetupDefaultBlobsIn(const std::vector<NDArray>& src,
+ const std::vector<NDArray> *bufs,
+ std::vector<TBlob> *blobs,
+ std::vector<NDArray> *temp_src,
+ std::vector<NDArray> *temp_dst,
+ std::unordered_map<uint32_t, uint32_t>
*idx_map) {
bool require_cast = false;
for (size_t i = 0; i < src.size(); i++) {
auto& nd = src[i];
- if (nd.storage_type() != kDefaultStorage) {
- if (idx_map != nullptr) {
- (*idx_map)[i] = temp_dst->size();
- }
- NDArray temp(nd.shape(), nd.ctx(), false, nd.dtype());
+ bool is_default = nd.storage_type() == kDefaultStorage;
Review comment:
CHECK / assert that idx_map is not null is missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
