szha commented on a change in pull request #9747: Add contrib.rand_log_uniform
URL: https://github.com/apache/incubator-mxnet/pull/9747#discussion_r168930990
##########
File path: python/mxnet/ndarray/contrib.py
##########
@@ -18,9 +18,81 @@
# coding: utf-8
# pylint: disable=wildcard-import, unused-wildcard-import
"""Contrib NDArray API of MXNet."""
+import math
+from ..context import current_context
+from ..random import uniform
try:
from .gen_contrib import *
except ImportError:
pass
-__all__ = []
+__all__ = ["log_uniform_candidate_sampler"]
+
+# pylint: disable=line-too-long
+def log_uniform_candidate_sampler(true_classes, num_sampled, range_max,
ctx=None):
Review comment:
should it go under contrib.random? since other sampling methods in random
just have the distribution as name, should we follow the same convention?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
