jinhuang415 commented on a change in pull request #9810: remove 
MKL_EXPERIMENTAL and update make files for MKL-DNN
URL: https://github.com/apache/incubator-mxnet/pull/9810#discussion_r169543124
 
 

 ##########
 File path: docker_multiarch/arm.crosscompile.mk
 ##########
 @@ -115,13 +100,10 @@ USE_LAPACK_PATH =
 USE_INTEL_PATH = NONE
 
 # If use MKL only for BLAS, choose static link automatically to allow python 
wrapper
-ifeq ($(USE_MKL2017), 0)
+USE_STATIC_MKL = NONE
 ifeq ($(USE_BLAS), mkl)
 USE_STATIC_MKL = 1
 
 Review comment:
   Thanks for the clarification, so do you mean USE_BLAS=mkl is used for using 
full MKL as blas library (and using static link)? If we want to use mklml as 
blas library (it is more light weighted if it support all blas API), how should 
we set the compile option? 
   
   I also notice there is some potential conflict here, if set USE_MKLDNN=1 and 
USE_BLAS=mkl, looks the generated libmxnet.so will both static link to mkl 
library and dynamic link to mklml library:
   Static link to mkl library:
   mshadow.mk line 63 
   MSHADOW_LDFLAGS += -L${MKLROOT}/../compiler/lib/intel64 -Wl,--start-group 
${MKLROOT}/lib/intel64/libmkl_intel_lp64.a ${MKLROOT}/lib/intel64/libmkl_core.a 
${MKLROOT}/lib/intel64/libmkl_intel_thread.a -Wl,--end-group -liomp5 -ldl 
-lpthread -lm
   
   Dynamic link to mklml library:
   mshadow.mk line 78: 
   MSHADOW_LDFLAGS += -Wl,--as-needed -lmklml_intel -lmklml_gnu 
   
   Is there any potential conflict here or indicate some issue need to fix? If 
both MKL and MKLML library could provide the blas API, which library it will 
use?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to