marcoabreu commented on a change in pull request #9810: remove MKL_EXPERIMENTAL 
and update make files for MKL-DNN
URL: https://github.com/apache/incubator-mxnet/pull/9810#discussion_r170200495
 
 

 ##########
 File path: Jenkinsfile
 ##########
 @@ -24,6 +24,7 @@
 mx_lib = 'lib/libmxnet.so, lib/libmxnet.a, dmlc-core/libdmlc.a, 
nnvm/lib/libnnvm.a'
 // mxnet cmake libraries, in cmake builds we do not produce a libnvvm static 
library by default.
 mx_cmake_lib = 'build/libmxnet.so, build/libmxnet.a, 
build/dmlc-core/libdmlc.a, build/tests/mxnet_unit_tests, 
build/3rdparty/openmp/runtime/src/libomp.so'
+mx_cmake_mkldnn_lib = 'build/libmxnet.so, build/libmxnet.a, 
build/dmlc-core/libdmlc.a, build/tests/mxnet_unit_tests, 
/usr/local/lib/libiomp5.so, /usr/local/lib/libmklml_gnu.so, 
build/3rdparty/mkldnn/install/lib/libmkldnn.so, 
build/3rdparty/mkldnn/install/lib/libmkldnn.so.0, 
/usr/local/lib/libmklml_intel.so'
 
 Review comment:
   I don't understand why we are generating files outside the source directory. 
This could cause issues because I would not assume that a compile process 
writes files to /usr/local or any other place outside of the source directory. 
Since I don't have much experience with cmake, I'd like to ask @larroy and 
@cjolivier01 for assistance here 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to