larroy commented on a change in pull request #9862: Fix a race condition in 
converting data layouts in MKLDNN.
URL: https://github.com/apache/incubator-mxnet/pull/9862#discussion_r170227496
 
 

 ##########
 File path: src/ndarray/ndarray.cc
 ##########
 @@ -1017,6 +1017,7 @@ inline void CopyFromToDnsImpl(const NDArray& from, const 
NDArray& to, RunContext
     // with Copy().
     NDArray tmp_from = from;
     if (tmp_from.IsMKLDNNData()) {
+      // TODO(zhengda) tmp_from should be cached.
 
 Review comment:
   Why don't we use dynamic dispatch in NDArray for different implementations 
and storage options? it would make the code more mainable. I predict Chris is 
going to mention the overhead of a virtual function but I don't think it would 
be significant also considering the conditional logic in some of the NDArray 
methods and Python overheads which are magnitudes higher.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to