zheng-da commented on a change in pull request #9862: Fix a race condition in 
converting data layouts in MKLDNN.
URL: https://github.com/apache/incubator-mxnet/pull/9862#discussion_r170326873
 
 

 ##########
 File path: src/ndarray/ndarray.cc
 ##########
 @@ -1017,6 +1017,7 @@ inline void CopyFromToDnsImpl(const NDArray& from, const 
NDArray& to, RunContext
     // with Copy().
     NDArray tmp_from = from;
     if (tmp_from.IsMKLDNNData()) {
+      // TODO(zhengda) tmp_from should be cached.
 
 Review comment:
   @larroy I agree with you that the current implementation of NDArray to 
handle storages is messy. What you said requires a rewrite of NDArray. 
@piiswrong and I talked about this, but I don't think this should be in this 
PR. We need to be very careful when rewriting NDArray, considering NDArray is 
one of the core components in MXNet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to