piiswrong commented on a change in pull request #8915: NVLink communication
pattern updated
URL: https://github.com/apache/incubator-mxnet/pull/8915#discussion_r170375469
##########
File path: src/kvstore/comm.h
##########
@@ -406,12 +422,12 @@ class CommCPU : public Comm {
});
}
- template<typename DType>
- inline static void ReduceSumCPU(
- const std::vector<DType*> &dptr, size_t offset, index_t size) {
+ template <typename DType>
+ inline static void ReduceSumCPU(const std::vector<DType*>& dptr,
Review comment:
This changes are really annoying
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
