ashokei commented on a change in pull request #9810: remove MKL_EXPERIMENTAL and update make files for MKL-DNN URL: https://github.com/apache/incubator-mxnet/pull/9810#discussion_r170442004
########## File path: docker_multiarch/arm.crosscompile.mk ########## @@ -115,13 +100,10 @@ USE_LAPACK_PATH = USE_INTEL_PATH = NONE # If use MKL only for BLAS, choose static link automatically to allow python wrapper -ifeq ($(USE_MKL2017), 0) +USE_STATIC_MKL = NONE ifeq ($(USE_BLAS), mkl) USE_STATIC_MKL = 1 Review comment: @jinhuang415 @marcoabreu MSHADOW can use MKLML (which is automatically selected when users build with MKLDNN); USE_BLAS=mkl is specifically for full mkl (not related to MKLML or MKLDNN). So there is no conflict here; Either of those options support full BLAS compatible API; mshadow handles both of these cases already; This PR or MKL-DNN integration PR , do not change this behavior. It is the same as before. As @zheng-da mentioned, we can modify mshadow to directly use MKL-DNN build flag in another PR. It wasnt done before, as we did not have MKL-DNN integration (we do now). This PR scope is limited to removing MKL_EXPERIMENTAL and cleaning up minor make file left overs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
