dabraude opened a new pull request #9883: added function for loading content of nd_array files URL: https://github.com/apache/incubator-mxnet/pull/9883 ## Description ## Adds a function for loading the content of an NDArray file. ## Checklist ## ### Essentials ### - [ ] Passed code style checking (`make lint`) - [ ] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [ ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - Added function MXNDArrayLoadFileContent ## Comments ## - As far as I can determine it is not possible for the current API to be able to load the content of an NDArray file without knowing a lot of details about the file format, saving the dtypes, and using both the c_api.h and the c_predict_api.h. - Not having this function is inconsistent with the symbol loading API which allows you to load from a file by name or by a string containing the JSON content. - required for issue #9827 - Not sure if you are happy with the names but that is the best I could come up with.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
