tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by 
TVM
URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368341749
 
 
   This being said, I totally agree that having proper testing is important. 
That is why there is already test-cases that get locally verified for these 
changes (which is also optional test that only runs when both are available in 
TVM side of changes). So the correctness and quality of the code change is 
covered by the 
[test_mxnet_bridge.py](https://github.com/tqchen/tvm/blob/master/tests/python/contrib/test_mxnet_bridge.py).
 
   
   The only question is that if we want to directly bring that testcase to this 
PR now, that involves bring TVM's build into current jenkins pipeline, which I 
think deserves some discussion before we do so.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to