aaronmarkham commented on a change in pull request #9878: Docs build all 
versions refactor
URL: https://github.com/apache/incubator-mxnet/pull/9878#discussion_r170488869
 
 

 ##########
 File path: docs/build_version_doc/setup_docs_ubuntu.sh
 ##########
 @@ -0,0 +1,42 @@
+# If you need to build <= v0.12.0 then use a Python 2 environment
+# mxdoc.py - a sphinx extension, was not Python 3 compatible in the old 
versions
+# source activate mxnet_p27
+
+# Install dependencies
+sudo apt-get update
 
 Review comment:
   This is taking a really long time to test, so that's why an update hasn't 
landed yet! I had the benefit of some deps handled by the DL AMI, but in a 
vanilla container I had a lot of troubleshooting to do. That being said, I'm 
hoping I'm near the end of testing the scripts inside a container for every tag 
we need.
   
   I'm quite tempted to modify the scripts though so that they take in the tag 
as an input and we do a `RUN` for each, so we can use the docker cache for when 
the build steps are completed fine.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to