marcoabreu commented on a change in pull request #9860: [WIP] CMake NNPack
support
URL: https://github.com/apache/incubator-mxnet/pull/9860#discussion_r170756315
##########
File path: CMakeLists.txt
##########
@@ -551,6 +552,37 @@ if(NOT EXISTS
"${CMAKE_CURRENT_SOURCE_DIR}/nnvm/CMakeLists.txt")
list(APPEND mxnet_LINKER_LIBS ${nnvm_LINKER_LIBS})
endif()
+# ---[ NNPack
+if(USE_NNPACK)
+ if (USE_MKLDNN)
+ message(WARNING "With MKLDNN enabled NNPack operators will not run.")
Review comment:
I'm not a fan of such implicit actions. It should be up to the user to
decide which Backend to use. To me, setting both options seems like a conflict
and should fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
