piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet URL: https://github.com/apache/incubator-mxnet/pull/9892#discussion_r170792427
########## File path: python/mxnet/contrib/serde/_import/common.py ########## @@ -0,0 +1,142 @@ +# Copyright 2017 Amazon.com, Inc. or its affiliates. All Rights Reserved. +# Licensed under the Apache License, Version 2.0 (the "License"). +# You may not use this file except in compliance with the License. +# A copy of the License is located at +# http://www.apache.org/licenses/LICENSE-2.0 +# or in the "license" file accompanying this file. This file is distributed +# on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either +# express or implied. See the License for the specific language governing +# permissions and limitations under the License. + +# Derived from Apache 2.0 licensed common.py file from DMLC NNVM: +# https://github.com/dmlc/nnvm/blob/3da53e46db57c438b05fbebe8aa332ee8c5994d1/python/nnvm/frontend/common.py + +# coding: utf-8 +# pylint: disable=invalid-name,no-self-use,too-many-branches,too-few-public-methods,too-many-arguments +"""Shared functions and classes for frontends.""" +from __future__ import absolute_import as _abs +from ....base import string_types + +class Renamer(object): Review comment: This class looks unnecessary ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
