anirudhacharya commented on a change in pull request #9892: [WIP] Serde Module
for Import/Export of models between Onnx and Mxnet
URL: https://github.com/apache/incubator-mxnet/pull/9892#discussion_r171388136
##########
File path: python/mxnet/contrib/serde/_import/__init__.py
##########
@@ -0,0 +1,26 @@
+# coding: utf-8
+"""import function"""
+import onnx
+from .import_onnx import GraphProto
+
+def import_model(model_file):
Review comment:
It will be used as follows -
```python
sym, params =
mxnet.contrib.onnx._import.import_model("super_resolution.onnx")
```
So onnx is already present in the package path.
Adding onnx in the method call could be redundant. It will get used like
this
```python
sym, params =
mxnet.contrib.onnx._import.import_onnx_model("super_resolution.onnx")
```
I am not sure if we would want that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
