cjolivier01 commented on a change in pull request #9933: Adding support to
profile kvstore server during distributed training
URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171447567
##########
File path: src/kvstore/kvstore_dist.h
##########
@@ -92,6 +92,14 @@ class KVStoreDist : public KVStoreLocal {
}
}
+ void SetServerProfilerCommand(KVStoreServerProfilerCommand type, const
std::string params) override {
Review comment:
please pass std::string by const reference
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
