tqchen commented on a change in pull request #9946: [DO NOT MERGE] Start CI 
docker revamp
URL: https://github.com/apache/incubator-mxnet/pull/9946#discussion_r171903273
 
 

 ##########
 File path: tests/ci_build/Dockerfile.cpu_clang
 ##########
 @@ -1,21 +0,0 @@
-FROM ubuntu:16.04
-
-COPY install/ubuntu_install_core.sh /install/
 
 Review comment:
   This is a bit like maintaining multiple cpp files for logically different 
functions. It seems to be not that different as long as everything is kept in 
one folder.
   
   The duplication can happen, however, in the docker file that you wrote, 
which is like copy a few lines of script invocation vs one line of invocation. 
   
   I personally have quite a lot pain rebuilding docker build every time I 
tried to add a new dep, especially for those that contain complicated source 
build like LLVM. So just talking my own experience so that at least we know the 
possible problem here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to