yajiedesign commented on a change in pull request #9940: remove set
CMAKE_GENERATOR_TOOLSET
URL: https://github.com/apache/incubator-mxnet/pull/9940#discussion_r172000000
##########
File path: CMakeLists.txt
##########
@@ -44,16 +44,16 @@ if(USE_CUDA AND NOT USE_OLDCMAKECUDA)
OR (${CMAKE_GENERATOR} STREQUAL "Unix Makefiles")
) AND (
(${CMAKE_VERSION} VERSION_GREATER "3.9.0") OR (${CMAKE_VERSION}
VERSION_EQUAL "3.9.0")
- )
+ ) AND NOT USE_OLDCMAKECUDA
Review comment:
else block set "FIRST_CUDA" to false,not set "USE_OLDCMAKECUDA".
Once the FIRST_CUDA is set up, it doesn't need to be checked USE_OLDCMAKECUDA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
