piiswrong commented on a change in pull request #9029: Update ndarray binary ops to use kernel launch instead of mshadow operations URL: https://github.com/apache/incubator-mxnet/pull/9029#discussion_r172750286
########## File path: src/ndarray/ndarray_function-inl.h ########## @@ -446,6 +468,11 @@ DECL_SCALAR(DEVICE, Minus, EvalScalar_, true) DECL_SCALAR(DEVICE, Mul, EvalScalar_, true) DECL_SCALAR(DEVICE, Div, EvalScalar_, true) +DECL_BINARY_LAUNCH(DEVICE, Plus) Review comment: why do you have both DECL_BINARY_LAUNCH and DECL_BINARY for Plus? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
