zheng-da commented on a change in pull request #9977: Cpu lstm inference
URL: https://github.com/apache/incubator-mxnet/pull/9977#discussion_r173038522
##########
File path: src/operator/rnn-inl.h
##########
@@ -287,8 +507,9 @@ class RNNProp : public OperatorProperty {
const std::vector<int> &out_grad,
const std::vector<int> &in_data,
const std::vector<int> &out_data) const override {
- std::vector<int> dep = {in_data[rnn_enum::kData],
in_data[rnn_enum::kParams],
- in_data[rnn_enum::kState], out_data[rnn_enum::kOut],
out_grad[rnn_enum::kOut]};
+ std::vector<int> dep = {in_data[rnn_enum::kData],
+ in_data[rnn_enum::kParams], in_data[rnn_enum::kState],
+ out_data[rnn_enum::kOut], out_grad[rnn_enum::kOut]};
Review comment:
the coding style in mxnet allows up to 100 char per line.
so the original code is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
