TaoLv commented on a change in pull request #9918: Update mkldnn to the newest 
& Add clang build test with mkldnn.
URL: https://github.com/apache/incubator-mxnet/pull/9918#discussion_r173041509
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_base.cc
 ##########
 @@ -237,13 +237,14 @@ mkldnn_memory_format_t 
GetDefaultFormat(mkldnn::memory::desc desc) {
       case mkldnn_gOIhw16o16i:
       case mkldnn_gIOhw16o16i:
       case mkldnn_gOihw8o:
+      case mkldnn_Goihw8g:
       case mkldnn_gOihw16o:
       case mkldnn_gOhwi8o:
       case mkldnn_gOhwi16o:
       case mkldnn_gOhIw16o4i:
         return mkldnn_goihw;
       default:
-        LOG(FATAL) << "Unknown MKLDNN format for 4 dimensions: " << 
desc.data.format;
+        LOG(FATAL) << "Unknown MKLDNN format for 5 dimensions: " << 
desc.data.format;
 
 Review comment:
   @marcoabreu Sorry for late response. It seems a little difficult to monitor 
the change of a `enum` type in mkldnn package. I have asked mkldnn team for 
support and am waiting for their reply. Since the mkldnn version updated in 
this pr works well with this part of code, I would like this pr be merged 
firstly and it will address the compilation issue on OSX. I will add unit test 
for it later if I get support from mkldnn team. If needed, I can help create a 
JIRA ticket to track this issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to