szha commented on a change in pull request #10025: Language model with Google's billion words dataset URL: https://github.com/apache/incubator-mxnet/pull/10025#discussion_r173680708
########## File path: python/mxnet/gluon/contrib/rnn/rnn_cell.py ########## @@ -181,3 +181,126 @@ def unroll(self, length, inputs, begin_state=None, layout='NTC', merge_outputs=N outputs, _, _, _ = _format_sequence(length, outputs, layout, merge_outputs) return outputs, states + + +class LSTMPCell(HybridRecurrentCell): Review comment: Good idea ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services