cjolivier01 commented on a change in pull request #10078: Support float16 in
L2Normalization operator
URL: https://github.com/apache/incubator-mxnet/pull/10078#discussion_r174012691
##########
File path: src/operator/l2_normalization.cc
##########
@@ -26,13 +26,22 @@
namespace mxnet {
namespace op {
template<>
-Operator* CreateOp<cpu>(L2NormalizationParam param) {
- return new L2NormalizationOp<cpu>(param);
+Operator* CreateOp<cpu>(L2NormalizationParam param, int dtype) {
Review comment:
is it done this way elsewhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
