anirudhacharya commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174319252
########## File path: python/mxnet/contrib/onnx/_import/import_helper.py ########## @@ -0,0 +1,105 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# coding: utf-8 +# pylint: disable=invalid-name +"""Operator attributes conversion""" +from .op_translations import identity, random_uniform, random_normal +from .op_translations import add, subtract, multiply, divide, absolute, negative, add_n +from .op_translations import tanh +from .op_translations import ceil, floor +from .op_translations import concat +from .op_translations import leaky_relu, _elu, _prelu, softmax, fully_connected +from .op_translations import global_avgpooling, global_maxpooling, linalg_gemm +from .op_translations import sigmoid, pad, relu, matrix_multiplication, batch_norm +from .op_translations import dropout, local_response_norm, conv, deconv Review comment: it is not as per mxnet convention to do ```python from op_translations import * ``` It was an earlier comment by one of the reviewers/committers. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
