[GitHub] marcoabreu commented on a change in pull request #10021: [MXNET-33] SSD example not working with mkl-dnn

[GitBox]

marcoabreu commented on a change in pull request #10021: [MXNET-33] SSD example 
not working with mkl-dnn
URL: https://github.com/apache/incubator-mxnet/pull/10021#discussion_r175165674
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h
 ##########
 @@ -92,12 +92,17 @@ inline bool SupportMKLDNNPooling(const PoolingParam &param,
 
   if (param.pooling_convention == pool_enum::kValid)
     return true;
+  else
+    return false;
 
+// need to support pooling convention full 
 
 Review comment:
   Please add a link to the issue as part of the comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services