eric-haibin-lin commented on a change in pull request #10213: [MXNET-16] move nnvm & dmlc-core to 3rdparty URL: https://github.com/apache/incubator-mxnet/pull/10213#discussion_r176796510
########## File path: .gitmodules ########## @@ -2,13 +2,13 @@ path = 3rdparty/mshadow url = https://github.com/dmlc/mshadow.git [submodule "dmlc-core"] Review comment: Good question. The name `ps-lite` remains unchanged when I use the `git mv` command to move the submodule to another folder. I agree that it makes sense to standardize. Let me try to update the name locally first ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services