haojin2 commented on a change in pull request #10208: [MXNET-117] Sparse operator broadcast_mul/div(csr, dense) = csr URL: https://github.com/apache/incubator-mxnet/pull/10208#discussion_r176890725
########## File path: src/operator/tensor/elemwise_binary_broadcast_op.h ########## @@ -76,6 +77,36 @@ inline bool BinaryBroadcastShape(const nnvm::NodeAttrs& attrs, return true; } +inline bool BinaryBroadcastMulStorageType(const nnvm::NodeAttrs& attrs, + const int dev_mask, + DispatchMode* dispatch_mode, + std::vector<int>* in_attrs, + std::vector<int>* out_attrs) { + CHECK_EQ(in_attrs->size(), 2U); + CHECK_EQ(out_attrs->size(), 1U); + const int lhs_stype = in_attrs->at(0); + const int rhs_stype = in_attrs->at(1); + int& out_stype = out_attrs->at(0); + bool dispatched = false; + // For GPU, directly fallback + if (dev_mask == mshadow::gpu::kDevMask) { Review comment: Done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services