eric-haibin-lin commented on a change in pull request #10183: [MXNET-120]
Float16 support for distributed training
URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r176900420
##########
File path: src/kvstore/kvstore_dist.h
##########
@@ -506,41 +514,46 @@ class KVStoreDist : public KVStoreLocal {
/**
* \brief convert to keys in ps
*/
- inline PSKV& EncodeDefaultKey(int key, size_t size, bool is_push) {
+ inline PSKV& EncodeDefaultKey(const int key, const size_t num_arr_elems,
Review comment:
Do you mind completing the param documentation for this function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
