rahul003 commented on a change in pull request #10183: [MXNET-120] Float16
support for distributed training
URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r176900514
##########
File path: src/kvstore/kvstore_dist.h
##########
@@ -228,17 +228,18 @@ class KVStoreDist : public KVStoreLocal {
RunContext rctx, Engine::CallbackOnComplete cb) {
// convert to ps keys
size_t size = recv_buf.shape().Size();
-
+ int dtype = recv_buf.dtype();
+ int elem_size = mshadow::mshadow_sizeof(dtype);
Review comment:
Haha, that's what I had originally. I changed it from `num_bytes` to
`elem_size` today evening! I changed it because I thought `num_bytes` was
conveying the meaning of total number of bytes as opposed to the number of
bytes for each element. Do you still think `num_bytes` is better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
