sandeep-krishnamurthy commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Adding ONNX Model zoo tests. URL: https://github.com/apache/incubator-mxnet/pull/10118#discussion_r177271405
########## File path: tests/python-pytest/onnx/onnx_backend_test.py ########## @@ -57,37 +57,40 @@ 'test_floor', ## Joining and spliting - #'test_concat.*', #---Failing test + 'test_concat', #Basic neural network functions 'test_sigmoid', 'test_relu', - #'test_constant_pad', - #'test_edge_pad', - #'test_reflect_pad', + 'test_constant_pad', + 'test_edge_pad', + 'test_reflect_pad', 'test_matmul', 'test_leakyrelu', 'test_elu', - #'test_softmax*', + 'test_softmax_example', + 'test_softmax_large_number', + 'test_softmax_axis_2', 'test_conv', 'test_basic_conv', - #'test_globalmaxpool', - #'test_globalaveragepool', - #'test_batch_norm', + 'test_transpose', + #'test_globalmaxpool', - tests to be added + #'test_globalaveragepool', - tests to be added + #'test_batch_norm', - tests to be added + #'test_gather', Review comment: Can you please add these tests as part of this PR, because, these operators are added in this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services