marcoabreu commented on a change in pull request #10202: [MXNET-131] Refine
build.py, misc fixes, tweak commandline, add help
URL: https://github.com/apache/incubator-mxnet/pull/10202#discussion_r177436655
##########
File path: ci/build.py
##########
@@ -48,7 +49,7 @@ def get_platforms(path: Optional[str]="docker"):
return platforms
-def get_docker_tag(platform: str) -> None:
+def get_docker_tag(platform: str) -> str:
Review comment:
This is only used in the CI environment or when a developer tries to
replicate a test failure locally, means this is basically a tool. I think we're
fine with separating (and deprecating) tools and the used versions from the
requirements we set for MXNet itself. No user will be using this script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
