zheng-da commented on a change in pull request #10336: Fix MKLDNN
sigmoid/softrelu issue
URL: https://github.com/apache/incubator-mxnet/pull/10336#discussion_r178500575
##########
File path: tests/python/unittest/test_gluon.py
##########
@@ -717,8 +717,8 @@ def test_lambda():
input_data = mx.nd.random.uniform(shape=(2, 3, 5, 7))
out1, out2, out3 = net1(input_data), net2(input_data), net3(input_data)
- assert_almost_equal(out1.asnumpy(), out2.asnumpy())
- assert_almost_equal(out1.asnumpy(), out3.asnumpy())
+ assert_almost_equal(out1.asnumpy(), out2.asnumpy(), rtol=1e-3)
+ assert_almost_equal(out1.asnumpy(), out3.asnumpy(), rtol=1e-3)
Review comment:
maybe we should set a smaller tolerance. changing from 1e-5 to 1e-3 seems to
be a big jump.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
