marcoabreu commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP Test
URL: https://github.com/apache/incubator-mxnet/pull/10365#issuecomment-378599212
 
 
   > @marcoabreu Regarding MKL-DNN, there's release version we can use. But the 
MXNET development progress is very fast so more new features (or bugfix) are 
needed. Thus, I think it's OK to select the master branch (based on a commit 
id). Each CI in MKL-DNN is fully verified and tested.
   https://github.com/intel/mkl-dnn/releases
   
   I'm indifferent about this one, at least for CI. My only concern is when we 
make a release with MXNet, we're unable to expect our users to use a 
(potentially) unstable master commit - usually people prefer to use a stable 
release. This means that users could run into problems because we're validating 
against a version of MKLDNN which is not even out yet. We have to consider this 
fact and have to find a solution - e.g. Intel making more frequent releases of 
the library, back-porting these fixes or something else along those lines. In 
the end, we don't want to make a release of MXNet that requires a dependency 
which is not even out yet. 
   
   
   > BTW, as we see enabling all test cases would be a great practice to 
improve the quality.
   
   Definitely! I appreciate efforts in that direction by a lot!
   
   
   Thanks a lot everybody for all your efforts!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to