szhengac commented on issue #10388: [MXNET-265] Update optimizer doc to clarify wd behaviors URL: https://github.com/apache/incubator-mxnet/pull/10388#issuecomment-378714141 I found the following line rescales the gradient outside the clipping function. This is inconsistent with other optimizers. https://github.com/eric-haibin-lin/mxnet/blob/90bb058bccb35df63366057d0538fb411f2f5151/python/mxnet/optimizer.py#L440
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services