cjolivier01 commented on a change in pull request #10317: [MXNET-264] Improve 
performance of MKLDNN in small batch sizes.
URL: https://github.com/apache/incubator-mxnet/pull/10317#discussion_r179325697
 
 

 ##########
 File path: include/mxnet/ndarray.h
 ##########
 @@ -74,6 +74,7 @@ enum NDArrayFormatErr {
   kRSPIdxErr,     // indices error for row sparse
 };
 
+class MKLDNNMemory;
 
 Review comment:
   one reason is that they cause annoying compile errors when used in pointer 
classes when code the compiler decides it needs the type in order to generate 
the destructor code, for instance or during template instantiation of something 
that uses it directly or indirectly. i’m not going to block the PR over it and 
if you feel
   strongly that you want to use it then fine, but it’s not done much in the 
code base and that’s probably not an accident.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to