marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN 
support for model quantization
URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r179747474
 
 

 ##########
 File path: tests/python/quantization/test_quantization_mkldnn.py
 ##########
 @@ -0,0 +1,309 @@
+# Licensed to the Apache Software Foundation (ASF) under one
 
 Review comment:
   Ideally, we would use the same set of tests for quantization on CPU and GPU 
since the underlying implementation should not influence the result.
   @reminisce what do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to