TaoLv commented on a change in pull request #10433: [MXNET-290] MKLDNN support 
for model quantization
URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r179772908
 
 

 ##########
 File path: tests/python/quantization/test_quantization_mkldnn.py
 ##########
 @@ -0,0 +1,309 @@
+# Licensed to the Apache Software Foundation (ASF) under one
 
 Review comment:
   Quantizations in this PR are implemented based on mkldnn APIs. So these 
tests should be run with mkldnn enabled. As you mentioned, in order to check 
the consistency with gpu implementation, is it possible to enable mkldnn on p3 
instance?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to