zheng-da commented on a change in pull request #10317: [MXNET-264] Improve 
performance of MKLDNN in small batch sizes.
URL: https://github.com/apache/incubator-mxnet/pull/10317#discussion_r179801695
 
 

 ##########
 File path: include/mxnet/ndarray.h
 ##########
 @@ -74,6 +74,7 @@ enum NDArrayFormatErr {
   kRSPIdxErr,     // indices error for row sparse
 };
 
+class MKLDNNMemory;
 
 Review comment:
   between including mkldnn_base-inl.h and forward declaration, i'll choose the 
latter. NDArray is such a basic class, its header file is included in almost 
every .cc files and many .h files, including mkldnn_base-inl.h. The other 
option is to define MKLDNNMemory in NDArray, if it's a preferred way. it's a 
little weird to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to