eric-haibin-lin commented on a change in pull request #10286: [MXNET-250] CSS 
and .htaccess fix
URL: https://github.com/apache/incubator-mxnet/pull/10286#discussion_r180163681
 
 

 ##########
 File path: docs/build_version_doc/update_all_version.sh
 ##########
 @@ -68,31 +73,51 @@ fi
 # Write all version numbers into $tag_file for AddVersion.py to use later
 # Master is added by that script by default
 for tag in $tag_list; do
-    if [ $tag != 'master' ]
-    then
-        echo "$tag" >> "$tag_file"
-    fi
+    echo "$tag" >> "$tag_file"
 done
 
+function update_mxnet_css {
+  tag=$1
+  echo "Begin update fixes.."
+  # All fixes are done on the master branch of mxnet-incubator repository
+  # During a nightly build, these fixes will be patched to all the versions in 
the asf-site repository including the master folder under versions directory.
+  # copy <master folder location> <version folder location>
+  
+  #SIM: https://sim.amazon.com/issues/AWSDBUX-19727
+  echo "Copying mxnet.css from master branch to all versions...."
+  cp "$MASTER_SOURCE_DIR/$STATIC_FILES_DIR/mxnet.css"  
"$built/versions/$tag/_static"
+
+  echo "Update fixes complete.."
+}
+
 # Update the specified tags with the Versions dropdown
 for tag in $tag_list; do
     # This Python script is expecting the tag_list.txt and it will use that as 
the entries to populate
+
     python AddVersion.py --root_url "$root_url" --file_path 
"$built/versions/$tag" --current_version "$tag" || exit 1
 
-    if [ $tag != 'master' ]
-    then 
-        python AddPackageLink.py --file_path 
"$built/versions/master/install/index.html" \
-                                                   --current_version "$tag" || 
exit 1
-    fi
+    #if [ $tag != 'master' ]
 
 Review comment:
   Remove unused code?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to