marcoabreu commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-380238440 I think the right place would be in the general unit test directory as well as in the GPU directory. Otherwise, we don't have coverage on CPU-only instances. Considering this API should be callable in any case and report the necessary information, I think we should test on CPU as well as on GPU. In the general test, you coukd make sure that API is callable in general and only throwing the expected errors - since we can't know on which instance we're running, it's hard to validate the actual return value. In the GPU test, could you simply check whether the return value is > 0.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
