aaronmarkham commented on a change in pull request #10485: [MXNET-304][RFC] 
Jenkins docs build
URL: https://github.com/apache/incubator-mxnet/pull/10485#discussion_r180843312
 
 

 ##########
 File path: ci/docker/install/ubuntu_docs.sh
 ##########
 @@ -21,8 +21,44 @@
 # the whole docker cache for the image
 
 set -ex
-wget http://downloads.lightbend.com/scala/2.11.8/scala-2.11.8.deb && \
-    dpkg -i scala-2.11.8.deb && rm scala-2.11.8.deb
+# Install dependencies
+echo 'Installing dependencies...'
+apt-get install -y \
+    apt-transport-https \
+    build-essential \
+    ca-certificates \
+    curl \
+    doxygen \
+    git \
+    libatlas-base-dev \
 
 Review comment:
   None of these are versioned at any point. I'd argue that while layering 
makes sense, it opens things up to breakage when we don't know what the full 
stack is for docs. For example, one of my deps, `libatlas-base-dev ` is only 
appearing in the Caffe script. If scripts gets pulled out for some reason, then 
docs may break. 
   
   `libjemalloc-dev` doesn't appear anywhere in the other scripts despite every 
build run telling you that you should have it installed (to massive improve 
speed, or so it contends).
   
   These seem like they should move to the base script:
   ```
       apt-transport-https \
       ca-certificates \
       software-properties-common \
   ```
   
   These would seem to not be relevant to CI, but I imagine if tutorials are 
being automatically executed then they're required, but at what layer? Just for 
docs?
   ```
       curl \
       unzip \
       wget
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to