ankkhedia commented on a change in pull request #10424: [MXNET-185] Improved 
error message
URL: https://github.com/apache/incubator-mxnet/pull/10424#discussion_r180941675
 
 

 ##########
 File path: python/mxnet/gluon/block.py
 ##########
 @@ -520,11 +520,11 @@ def _infer_attrs(self, infer_fn, attr, *args):
                 **{i.name: getattr(j, attr) for i, j in zip(inputs, args)})
             if arg_attrs is None:
                 raise ValueError(w[0].message)
-            sdict = {i: j for i, j in zip(out.list_arguments(), arg_attrs)}
-            sdict.update({name : attr for name, attr in \
-                 zip(out.list_auxiliary_states(), aux_attrs)})
-            for i in self.collect_params().values():
-                setattr(i, attr, sdict[i.name])
+        sdict = {i: j for i, j in zip(out.list_arguments(), arg_attrs)}
 
 Review comment:
   arg_attrs and aux_attrs will be none at this point since they obtain values 
within warning block and you have moved this chunk of code outside warning 
block. Wouldn't that be the case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to