aaronmarkham commented on a change in pull request #10534: [MXNET-315] Fix the
version select in the navbar to be independent of order
URL: https://github.com/apache/incubator-mxnet/pull/10534#discussion_r181246453
##########
File path: docs/build_version_doc/update_all_version.sh
##########
@@ -93,7 +93,7 @@ function update_mxnet_css {
for tag in $tag_list; do
# This Python script is expecting the tag_list.txt and it will use that as
the entries to populate
- python AddVersion.py --root_url "$root_url" --file_path
"$built/versions/$tag" --current_version "$tag" || exit 1
+ python AddVersion.py --root_url "$root_url" --file_path
"$built/versions/$tag" --current_version "$tag" --default_tag "$tag_default" ||
exit 1
Review comment:
Did you need to flip the argument or could you be consistent?
default_tag vs tag_default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
