lebeg commented on issue #9940: [MXNET-46]remove set CMAKE_GENERATOR_TOOLSET URL: https://github.com/apache/incubator-mxnet/pull/9940#issuecomment-381669082 I think this is indeed a very good change. I am sure that there are alternatives to hardcoding things into CMakeLists.txt with documented dangers of undefined behaviour. Checkout another improvement from my side https://github.com/apache/incubator-mxnet/pull/10564
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
