KellenSunderland commented on a change in pull request #10566: [MXNET-324] Use
default nvcc when configured nvcc not present.
URL: https://github.com/apache/incubator-mxnet/pull/10566#discussion_r181880161
##########
File path: Makefile
##########
@@ -255,11 +255,26 @@ ifneq ($(ADD_LDFLAGS), NONE)
endif
ifeq ($(NVCC), NONE)
+ # If NVCC has not been manually defined, use the CUDA_PATH bin dir.
ifneq ($(USE_CUDA_PATH), NONE)
NVCC=$(USE_CUDA_PATH)/bin/nvcc
endif
endif
+# Gaurd against displaying nvcc info messages to users not using CUDA.
+ifeq ($(USE_CUDA), 1)
+ # If NVCC is not at the location specified, use CUDA_PATH instead.
+ ifeq ("$(wildcard $(NVCC))","")
Review comment:
I'm surely not a Makefile expert, but I assume None is getting picked up
from the config files, i.e. here:
https://github.com/apache/incubator-mxnet/blob/master/make/config.mk#L69
Yes this is file exists, testable by editing the config's nvcc to point to
various exiting and non-existing paths, then observing logging messages.
Documented quite well here:
http://www.humbug.in/2012/makefile-check-if-a-file-exists-using-wildcard-function/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
