haojin2 commented on a change in pull request #10585: [MXNET-329] support
SparseEmbedding with dense weight
URL: https://github.com/apache/incubator-mxnet/pull/10585#discussion_r182565612
##########
File path: tests/python/unittest/test_sparse_operator.py
##########
@@ -1638,10 +1638,10 @@ def check_sparse_elementwise_sum_with_shape(stype,
shape, n):
@with_seed()
def test_sparse_embedding():
''' test sparse embedding operator '''
- def check_sparse_embedding(in_dim, out_dim, batch, densities,
deterministic):
+ def check_sparse_embedding(in_dim, out_dim, batch, densities,
deterministic, weight_stype):
Review comment:
What about change the name to "check_deterministic"? "deterministic" does
not sound really straightforward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
